search

envoyproxy / envoy-mobile

Client HTTP and networking library based on the Envoy project for iOS, Android, and more.
https://envoymobile.io
Apache License 2.0
557 stars 84 forks source link

Rename release_validator to validation_cleanup #2701

Closed RyanTheOptimist closed 1 year ago

RyanTheOptimist commented 1 year ago

Rename release_validator to validation_cleanup. The release_validator function does not actually release the validator. On iOS is does nothing and on Android it merely detaches the JVM from the current thread. So "cleanup validation" is a better description of it's function than "release validator" and matches the existing description "to clean up after validation completion."

Signed-off-by: Ryan Hamilton rch@google.com

RyanTheOptimist commented 1 year ago

/assign @alyssawilk

RyanTheOptimist commented 1 year ago

/assign @alyssawilk