search

envoyproxy / envoy-mobile

Client HTTP and networking library based on the Envoy project for iOS, Android, and more.
https://envoymobile.io
Apache License 2.0
562 stars 84 forks source link

ci: run size comparisons for iOS/Android release artifacts on PRs #865

Open rebello95 opened 4 years ago

rebello95 commented 4 years ago

At the moment, the coverage job only compares size differences with the core artifact. Adding jobs to additionally do size comparisons of the iOS/Android artifacts would help us catch issues like https://github.com/lyft/envoy-mobile/pull/864 where Bazel rules or compilation logic changes on only one platform.

rebello95 commented 4 years ago

Something to also consider is whether we want to only validate relative size increases on PRs or to also limit the total size of the artifacts