search

envoyproxy / envoy-openssl

Envoy OpenSSL extensions
Apache License 2.0
44 stars 38 forks source link

Fix sanitisers compilation in PR#113 #114

Closed dcillera closed 9 months ago

dcillera commented 10 months ago

Compilation option for sanitisers added in cmake configuration

dcillera commented 10 months ago

I think we also need a target_compile_options(...) for the bssl-compat library target

And target_link_options too?

tedjpoole commented 10 months ago

No, target_link_options() is only needed on the executable targets utests-boring and utests-bssl-compat

tedjpoole commented 9 months ago

@dcillera do you want to continue with this PR, or do you think it would be better to start another using the work you subsequently did using arsenm/sanitizers-cmake?

dcillera commented 9 months ago

@tedjpoole I think it's better to create a new one.

tedjpoole commented 9 months ago

Superseded by #121