Replaced envoy git submodule with a bazel http_archive

envoyproxy / envoy-openssl

Envoy OpenSSL extensions

Apache License 2.0

44 stars 38 forks source link

Closed tedjpoole closed 9 months ago

tedjpoole commented 9 months ago

This PR rreplaces the envoy local_repository() with a http_archive().

Advantages:

Much faster for bazel to download the envoy source zip, compared to git fetching a submodule
bazel automatically applies the patch files to the envoy source, eliminating the manual patching step

Disdvantages:

Some files need to be duplicated from the envoy repo into the envoy/ directory
These duplicated files need to be kept up to date when the envoy version changes

phlax commented 9 months ago

@tedjpoole we have a workflow trigger system set up with some of our downstreams so they get notified on commits to envoy and can sync/update/etc

lmk if that would be helpful here

tedjpoole commented 9 months ago

@phlax thanks for the heads up. At the moment we're just using a fixed envoy version, but setting up some automatic tracking in future would be great

tedjpoole commented 9 months ago

@twghu This PR provides the mechanism for you to overwrite/replace whole files in the envoy source tree.