envoyproxy / envoy-openssl

Envoy OpenSSL extensions
Apache License 2.0
46 stars 44 forks source link

openssl: version update and BUILD fixes #13

Closed mythi closed 4 years ago

mythi commented 4 years ago

Nothing depends on @openssl//:build so the OpenSSL headers and libaries are not installed. This triggers build failures in environments that have no system openssl headers installed (such as envoy-build-ubuntu container).

The Bazel documentation says all dependencies must be explicitly declared in srcs. Adding openssl_headers to @openssl//:ssl srcs sets the dependency to @openssl//:build and the build passes.

A simple test case to run:

envoy/ci/run_envoy_docker.sh 'bazel build //:envoy'

And while we're at it:

Closes: #5 Closes: #12

Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com

venilnoronha commented 4 years ago

Do you also want to uncomment the build/test targets in the AZP?

https://github.com/envoyproxy/envoy-openssl/blob/fc27c51c9d57ec4617ca4cc62406765d7fa9b079/.azure-pipelines/linux.yaml#L12-L45

mythi commented 4 years ago

@venilnoronha I was planning on doing that once I get my Envoy improvements accepted: https://github.com/envoyproxy/envoy/pull/9535

rojkov commented 4 years ago

LGTM. Merging...