search

envoyproxy / envoy-openssl

Envoy OpenSSL extensions
Apache License 2.0
46 stars 44 forks source link

[WIP] bazel: Use @boringssl instead of @openssl as a dependency #15

Closed vadorovsky closed 4 years ago

vadorovsky commented 4 years ago

This commit changes the reference from @openssl to @boringssl as a dependency. The reason for that change is fixing the repository mapping and being able to use OpenSSL as a shared library.

Before this change, even if someone modified the WORKSPACE file and changed the mapping from @boringssl to @openssl_shared (instead of @openssl), Bazel was still using the bundled tarball for building boringssl_compat, so the tarbal was downloaded and used instead of the shared lib.

Signed-off-by: Michal Rostecki mrostecki@opensuse.org

mythi commented 4 years ago

@mrostecki thanks. This seems to trigger a CI failure. Are you able to reproduce it locally?

mythi commented 4 years ago

after taking a closer look, I believe the CI test is faulty. Care to address that too?

vadorovsky commented 4 years ago

after taking a closer look, I believe the CI test is faulty. Care to address that too?

Yes, I will take care of that. That CI test seems to assume that using @boringssl repo as a dep is not right. Which is an incorrect assumption, since correctly configured WORKSPACE is always going to map boringssl to something else.

That test should maybe check whether to what libraries the produces binary is linked. I will try to do that today.

vadorovsky commented 4 years ago

I realized now that this pull request is incorrect. We re-map @boringssl repository only inside Envoy workspace.

The real problem is that we use @openssl repository inside envoy-openssl code, which means, that bssl_wrapper is always going to use OpenSSL downloaded from tarball instead of shared library.

I have an idea how to fix that properly, I will send a separate PR and close this one.