envoyproxy / envoy-openssl

Envoy OpenSSL extensions
Apache License 2.0
47 stars 45 forks source link

Added BIGNUM & ERR functions & tests #70

Closed tedjpoole closed 1 year ago

tedjpoole commented 1 year ago

Also:

Signed-off-by: Ted Poole tpoole@redhat.com

pfl commented 1 year ago

When doing 'cmake ..' I get output saying

...
Copied openssl/x509_vfy.h
Copied openssl/x509v3.h
2 out of 2 hunks FAILED -- saving rejects to file /envoy-openssl/bssl-compat/source/crypto/bytestring/cbs.c.rej
Copied crypto/bytestring/cbs.c (patched)
Copied crypto/bytestring/cbb.c
Copied crypto/bytestring/internal.h
3 out of 3 hunks FAILED -- saving rejects to file /envoy-openssl/bssl-compat/source/crypto/asn1/a_int.c.rej
Copied crypto/asn1/a_int.c (patched)
2 out of 2 hunks FAILED -- saving rejects to file /envoy-openssl/bssl-compat/source/crypto/internal.h.rej
Copied crypto/internal.h (patched)
...

Are these supposed to fail?

tedjpoole commented 1 year ago

No those failures are not expected. It will probably be due to small differences in the OpenSSL headers between versions. The patching mechanism probably needs some more thought to deal with this

pfl commented 1 year ago

No those failures are not expected. It will probably be due to small differences in the OpenSSL headers between versions. The patching mechanism probably needs some more thought to deal with this

I had the wrong version of the boringssl submodule checked out. Works fine now.