Closed Rainton closed 4 years ago
This PR includes some code refactoring:
Renamed csdspb to csdspb_v2 and changed Client into an interface{} for adding support for csdspb_v3 in the future
csdspb
csdspb_v2
Client
csdspb_v3
Created ClientV2 which implements Client
ClientV2
Moved ParseFlags() in the main to make code more reusable discussion with @alexburnos
ParseFlags()
Extracted default values for flags out into constants discussion with @dschaller
Added csdsv2_mock.go mock CSDS server generated by gomock for future tests
csdsv2_mock.go
Renamed flag -cloud_platform to -platform
-cloud_platform
-platform
Signed-off-by: Yutong Li yutongli@google.com /cc @fuqianggao @alexburnos
/cc @htuch @dschaller @dio @therealmitchconnors
@alexburnos @fuqianggao please let me know if the recent changes resolve your concern. Thanks!
This PR includes some code refactoring:
Renamed
csdspb
tocsdspb_v2
and changedClient
into an interface{} for adding support forcsdspb_v3
in the futureCreated
ClientV2
which implementsClient
Moved
ParseFlags()
in the main to make code more reusable discussion with @alexburnosExtracted default values for flags out into constants discussion with @dschaller
Added
csdsv2_mock.go
mock CSDS server generated by gomock for future testsRenamed flag
-cloud_platform
to-platform
Signed-off-by: Yutong Li yutongli@google.com /cc @fuqianggao @alexburnos