envoyproxy / envoy-tools

Companion tooling for Envoy proxy
Apache License 2.0
49 stars 24 forks source link

[csds-client] Don't fail parsing csds response if it contains unknown type #28

Closed fuqianggao closed 3 years ago

fuqianggao commented 3 years ago

Right now, https://github.com/Rainton/envoy-tools/blob/79d6c9d00e61b06cdcda3734659c8e45f8f58ac3/csds-client/client/util/util.go#L70 will return not found if a certain type url is not explicitly linked. This is fragile and will result in csds client tool error out.

Instead, can we consider ignore if can't find, and print out the message as is (the content for the missing type will not be human readable, but we still get to see the rest)

fuqianggao commented 3 years ago

/cc @Rainton