envoyproxy / envoy-tools

Companion tooling for Envoy proxy
Apache License 2.0
49 stars 24 forks source link

Add support for TRAFFICDIRECTOR_MESH_SCOPE_NAME #40

Closed plasticproxy closed 2 years ago

plasticproxy commented 2 years ago

Address https://github.com/envoyproxy/envoy-tools/issues/39

fuqianggao commented 2 years ago

/cc @Rainton PTAL.

/cc @htuch @adisuissa for owner approval once this has LGTM from @Rainton

plasticproxy commented 2 years ago

bump

adisuissa commented 2 years ago

@htuch can you please take a final pass?

htuch commented 2 years ago

@fuqianggao do you know what's up with CI?

fuqianggao commented 2 years ago

@plasticproxy re-kick CI?

@fuqianggao do you know what's up with CI?

@plasticproxy re-kick CI to see if it go through?

plasticproxy commented 2 years ago

I've added an empty commit to re-run checks, but it says First-time contributors need a maintainer to approve running workflows.