envoyproxy / envoy-tools

Companion tooling for Envoy proxy
Apache License 2.0
49 stars 24 forks source link

csds v3 autogenerate node.id by using randomly generated uuid #58

Closed manish-annappa closed 9 months ago

manish-annappa commented 11 months ago

ClientStatusRequest in CSDS V3 has additional field node to identify the id of the node making the request. This node.id is used to apply IAM policy. This is a common pattern across the other xDS protocols as well. Presence of this field is required while making CSDS V3 request to Traffic Director. However, in CSDS the requestor can be any other instance other than envoy proxy. The check is only done for the node id prefix path to have valid resource path with project number and mesh/network name. So the actual node id can be randomly generated so that the users don't have to explicitly pass a node id.

manish-annappa commented 11 months ago

@adisuissa PTAL

manish-annappa commented 11 months ago

@plasticproxy PTAL