Unify URL parsing with GoogleURL - Githubissues

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy

https://www.envoyproxy.io

Apache License 2.0

25.04k stars 4.82k forks source link

Unify URL parsing with GoogleURL #15290

Open asraa opened 3 years ago

asraa commented 3 years ago

Two concerns:

llhttp (http-parser replacement) does not have a URL parser: https://github.com/nodejs/llhttp/issues/7. Derek brought up this concern in that issue.
The fewer different URL parsing stuff we have, the better.

Envoy uses http_parser_url to split the URL into pieces.

We should replace this with GoogleURL, which does URL parsing (https://chromium.googlesource.com/chromium/src/+/master/url#parsing). See https://chromium.googlesource.com/chromium/src/+/master/url/gurl.h#340

Related Issues: https://github.com/envoyproxy/envoy/issues/5155 https://github.com/envoyproxy/envoy/issues/6588

Can we bring back https://github.com/envoyproxy/envoy/pull/11670?

cc @derekargueta @dio @envoyproxy/security-team

dio commented 3 years ago

I think @yanavlasov has a relevant plan for this, I'll try to propose something, but it will be good to hear from Yan first :).