Open hshamji opened 2 years ago
What you will see is that admission control does not implement the createRouteSpecificFilterConfigTyped
method on the config. I don't think it would be too terribly hard to do this if you want to give it a shot. cc @tonya11en
vs.
https://github.com/envoyproxy/envoy/blob/main/source/extensions/filters/http/rbac/config.h
Hi @mattklein123 , I would like to work on this issue if no one has picked this up yet.
I was hoping to take a stab at this. I'm a newbie to the codebase so I'll take a little getting up to speed. Love to pair on this if you'd be interested.
No one else is working on this that I know so I will let the two of you sort it out!
I'm happy to review the PR, when you're ready!
Any updates on the progress of this? If not, I can take a stab.
No progress. Pls feel free!
It's worth pointing out that a lot of the cases where this feature was needed are covered now with the ability to use this as an upstream filter (https://github.com/envoyproxy/envoy/pull/23071).
I have a weird use case where I need to differentiate based on routes to the same cluster.
I have a weird use case where I need to differentiate based on routes to the same cluster.
Tag me in the PR when you're ready and I can review.
QUESTION: Admission Control Non-Global Configurations
Description: When I try to configure Admission Control for a specific route I get the error that
The filter envoy.filters.http.admission_control doesn't support virtual host-specific configurations
.I'm trying to understand the limits of this. Could I for example split traffic on headers and apply Admission Control to one set of headers? I'm still getting my bearings in the codebase, but I think this wouldn't be possible, right?
What would the complexity (and interest) be in a patch to make this filter available for virtual host-specific configurations, ex. for different headers, or different subpaths.
Thank you,