envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.99k stars 4.81k forks source link

Add a virtual cluster stat for when a downstream stream termination occurs #23866

Open Augustyniak opened 2 years ago

Augustyniak commented 2 years ago

Description: Add a virtual cluster stat that's emitted when a downstream stream is terminated before a given stream (request) completes. This is important from the perspective of Envoy Mobile and mobile clients in general. In mobile environment it a request - an Envoy downstream stream - can be started and terminated soon after (before the stream has a chance to finish) as a result of certain user's interaction in the mobile app.

Currently, virtual cluster's stats do not capture information about the termination of such request. When a request starts, upstream_rq_total stat is incremented but there is not corresponding "request completion" stat that gets incremented when a downstream stream is terminated.

Some of the ideas for the proposed stat name (ordered list):

Relevant Links: The list of currently available virtual cluster stats can be found at https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#virtual-clusters.

phlax commented 2 years ago

cc @jmarantz

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.