search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.25k stars 4.68k forks source link

stats: add a config options that allow to disable all counters, gauges, histograms #25074

Open Augustyniak opened 1 year ago

Augustyniak commented 1 year ago

Title: Add a config options that allow to disable all counters, gauges, histograms

Description: The feature could be useful in general but it's especially interesting from the perspective of mobile clients. Since the aggregation of gauges and histogram data across millions of mobile clients is a non trivial thing to do it may be pretty common for the users of Envoy Mobile to want to disable all gauges and/or histograms to save on CPU/mem/data bandwidth usage.

jmarantz commented 1 year ago

See also https://github.com/envoyproxy/envoy/issues/14051

We can't disable some stats without affecting functionality. I suspect histograms should be fine to disable, but we need to prevent Envoy production code from making decisions based on counter/gauge values before we introduce more foot-guns to disable stats en masse and break things.

jmarantz commented 1 year ago

More specifically, I'd recommend adding disablement of histograms. But I think we should solve #14051 before adding disabling of counters or gauges. I don't think #14051 is that hard to solve but it will be some effort.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.