Closed phlax closed 1 year ago
There is a file that fails clang-tidy but as it is only run as clang-tidy-diff it only surfaces when the file is touched.
clang-tidy
clang-tidy-diff
Running clang-tidy-diff against HEAD^ (7850b6bb6494e3bfc093b1aff20282ab30b67940), current HEAD (bb554f53ad8d3a2a2ae4cbd7102a3e20ae00b558) /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy/source/common/http/http1/balsa_parser.h:61:8: error: invalid case style for function 'ProcessHeadersOrTrailersImpl' [readability-identifier-naming,-warnings-as-errors] void ProcessHeadersOrTrailersImpl(const quiche::BalsaHeaders& headers); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ processHeadersOrTrailersImpl 14982 warnings generated. 43352 warnings generated. 54685 warnings generated. Writing fixes to clang-tidy-fixes.yaml ... clang-tidy check failed, potentially fixed by clang-apply-replacements: Diagnostics: - BuildDirectory: /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy DiagnosticMessage: FileOffset: 2637 FilePath: source/common/http/http1/balsa_parser.h Message: invalid case style for function 'ProcessHeadersOrTrailersImpl' Replacements: - FilePath: source/common/http/http1/balsa_parser.h Length: 28 Offset: 2637 ReplacementText: processHeadersOrTrailersImpl DiagnosticName: readability-identifier-naming Level: Warning MainSourceFile: ''
https://dev.azure.com/cncf/envoy/_build/results?buildId=128469&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=21e6aa7d-f369-5abd-5e4e-e888cac18e9c&l=507
cc @bencebeky
/assign @bencebeky
thanks @bencebeky !
related to #24485
There is a file that fails
clang-tidy
but as it is only run asclang-tidy-diff
it only surfaces when the file is touched.Ci log
Ci failure
https://dev.azure.com/cncf/envoy/_build/results?buildId=128469&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=21e6aa7d-f369-5abd-5e4e-e888cac18e9c&l=507
Contributors that may have further context
cc @bencebeky