search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.92k stars 4.8k forks source link

Improve docs and/or process of building a Docker image from release #28755

Closed phlax closed 1 year ago

phlax commented 1 year ago

The ci release target and Docker build have been changed and the docs no longer reflect accurately the steps needed to build a docker image

The docker build expects a tarball in the right place and structured correctly, so we need to update the docs to reflect that

Also, in general, the best Docker image to build is the distroless variant - so we should probably document that also

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

nezdolik commented 1 year ago

+1 on the stale docs, could not build the docker image for quite some time following the docs

phlax commented 1 year ago

funny - i was just thinking about this

ill try and get to it this week

nezdolik commented 1 year ago

lmk if i could help, am figuring out how to build right now :)

phlax commented 1 year ago

best advice is to see what it does in ci

the slight issue is that currently only the release path builds the correct tarball - i will update release.server_only asap to work ~the same

then its a case of making the tarball be in the right place