envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.95k stars 4.8k forks source link

Regarding envoy api dependency compatibility problem #28963

Closed Gaurav0411GitHub closed 1 year ago

Gaurav0411GitHub commented 1 year ago

We have upgraded envoy 1.17.4 to envoy 1.26.1. I have made below corresponding api dependency and it's version. But we are not able to find envoy api dependency in envoy 1.26.1 corresponding udpa.

I have collected this table data from the below link https://www.envoyproxy.io/docs/envoy/v1.26.1/intro/arch_overview/security/external_deps https://www.envoyproxy.io/docs/envoy/v1.17.4/intro/arch_overview/security/external_deps

Capture

Please let us know what is the corresponding udpa api for envoy 1.26.1

phlax commented 1 year ago

udpa is (gradually) being renamed to xds - check the xds dep here https://www.envoyproxy.io/docs/envoy/v1.26.1/intro/arch_overview/security/external_deps#external-dependencies-api

Gaurav0411GitHub commented 1 year ago

Thanks for your help for udpa. We are using envoy for c++ code. I need help for below 3 dependencies also

  1. There is only validate folder in protoc-gen-validate-0.10.1 but previously we were using gogoproto and validate folder so from where we can take gogoproto folder in protoc-gen-validate-0.10.1.
  2. There is only cds.proto and BUILD file is available inside /envoy/api/envoy/service/cluster/v3/ folder. How can we get cds_1.grpc.pb.cc cds_1.pb.cc cds.grpc.pb.h cds.pb.h files.
  3. In client_model-147c58e9608a4f9628b53b6cc863325ca746f63a also, I am not able to find metrics_3.grpc.pb.cc metrics_3.pb.cc metrics.grpc.pb.h metrics.pb.h files, How can we get these files
yanavlasov commented 1 year ago
  1. gogo support was removed from protoc-gen-validate. https://github.com/bufbuild/protoc-gen-validate/pull/340 You can ask in gogo forums about its status
  2. You need to generate them using protobuf compiler. This is gRPC doc: https://grpc.io/docs/languages/cpp/basics/
  3. I assume it is the same as 2
Gaurav0411GitHub commented 1 year ago

Thanks for your suggestion. I am new for gRPC and protocol buffers. I have upgraded envoy 1.17.4 to envoy 1.26.1 but Now I want to upgrade envoy api and its dependencies. Like I want to generate all .cpp and h for folder /envoy/api/envoy so please let me know how can I generate files recursively on this complete folder

Gaurav0411GitHub commented 1 year ago

Is there anyway to compile all the dependencies at once and generating .cc and .h file? Please ping me that steps so that we can get in simple way?

yanavlasov commented 1 year ago

It depends on what build system you are using. The https://grpc.io/docs/languages/cpp/basics/ explains how to use CMake. If you use bazel you can use build macros that Envoy is using, check out how https://github.com/envoyproxy/nighthawk for example.

Gaurav0411GitHub commented 1 year ago

Thanks for your help I have generated envoy api and envoy api dependencies after compiling I am getting below compilation error

envoy/data/tap/v2alpha/wrapper.pb.cc:93:6: error: ‘::descriptor_table_udpa_2fannotations_2fstatus_2eproto’ has not been declared &::descriptor_table_udpa_2fannotations_2fstatus_2eproto, ^~~~~~~~~~~~ ... envoy/data/tap/v2alpha/wrapper.pb.cc:93:6: note: suggested alternative: ‘descriptor_table_google_2fprotobuf_2fstruct_2eproto’ &::descriptor_table_udpa_2fannotations_2fstatus_2eproto, ^~~~~~~~~~~~ descriptor_table_google_2fprotobuf_2fstruct_2eproto

I have just generated these files so I can't declare these structures so please help me how can I resolve this error

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.