search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.87k stars 4.78k forks source link

Filesystem xDS does not detect all changes on Windows #30016

Open dimo414 opened 1 year ago

dimo414 commented 1 year ago

Description:

I am using xDS configs via the filesystem on Windows and observed that my config files were not being picked up, despite the same behavior working correctly on Linux. I believe I have narrowed it down to an issue with how filesystem events on Windows are being monitored, because I was able to trigger config refreshes manually even though my application logic wasn't working.

My existing code (which works on Linux) looks like so:

with tempfile.NamedTemporaryFile(delete=False, mode="w", encoding="utf-8") as f:
  prepare_jinja_template(...).dump(f)
os.replace(f.name, self.xds_files.lds)

The fix is:

with tempfile.NamedTemporaryFile(dir=os.path.dirname(self.xds_files.lds), delete=False, mode="w", encoding="utf-8") as f:
  prepare_jinja_template(...).dump(f)
os.replace(f.name, self.xds_files.lds)

That is to say, on Windows filesystem updates are only considered valid if the source file is in the same directory as the watched destination file.

To me this seems like a bug in the Windows file watching implementation, but if this is considered WAI this limitation should be clearly documented - none of the documentation I've looked at mentions any constraints about where the replacement file comes from.

Repro steps:

  1. Run a filesystem-backed xDS config on Windows
    • Optionally enabling debug logging for config and file (this isn't needed but makes the issue easier to observe)
  2. Prepare a change to the xDS config files in a different directory than the directory being watched
  3. Using Python's os.replace() or another atomic filesystem operation move the prepared change into place
  4. Observe that the new files have not been picked up by Envoy

Config:

(sharing relevant parts from the /config_dump endpoint)

{
 "configs": [
  {
   "@type": "type.googleapis.com/envoy.admin.v3.BootstrapConfigDump",
   "bootstrap": {
    "node": {
     "id": "fe-1",
     "cluster": "fe",
     "user_agent_name": "envoy",
     "user_agent_build_version": {
      "version": {
       "major_number": 1,
       "minor_number": 27
      },
      "metadata": {
       "ssl.version": "BoringSSL",
       "revision.sha": "7bba38b743bb3bca22dffb4a21c38ccc155fbef8",
       "build.type": "RELEASE",
       "revision.status": "Modified"
      }
     },
     "extensions": [ ... ]
    },
    "dynamic_resources": {
     "lds_config": {
      "path_config_source": {
       "path": "C:\\Users\\adp\\AppData\\Local\\Temp\\adp-envoy-config-rsnoqfi9\\tmpz4wc4_19-lds.yaml"
      }
     },
     "cds_config": {
      "path_config_source": {
       "path": "C:\\Users\\adp\\AppData\\Local\\Temp\\adp-envoy-config-rsnoqfi9\\tmp68ivf_a2-cds.yaml"
      }
     }
    },
    "admin": {
     "address": {
      "socket_address": {
       "address": "0.0.0.0",
       "port_value": 10000
      }
     }
    }
   },
   "last_updated": "2023-10-07T02:22:56.092Z"
  },
  ...
 ]
}

Logs:

I started Envoy with --component-log-level=config:trace,file:trace,init:debug,http:debug,router:debug,admin:debug and have included below the init, config, file, and upstream logs.

Notice in particular the notification: handle: ... action: 1 and 2 lines; these correspond to this logging statement and the numbers reference FILE_ACTION_* constants, where 1 and 2 are added and removed, respectively. These events were triggered by os.replace() calls in our application, but do not result in a config refresh in Envoy. Further down there is a pair of action: 4 and action: 5 events (file renamed from and to, respectively) that do trigger a config refresh. This was caused by me manually copying the config file within the current directory and then overwriting it via os.replace() in the terminal. The only difference between the automated overwrites and my manual one is the location of the source file.

[2023-10-06 14:54:14.668][1580][info][config] [source/server/configuration_impl.cc:144] loading tracing configuration
[2023-10-06 14:54:14.668][1580][info][config] [source/server/configuration_impl.cc:103] loading 0 static secret(s)
[2023-10-06 14:54:14.668][1580][info][config] [source/server/configuration_impl.cc:109] loading 0 cluster(s)
[2023-10-06 14:54:14.669][1580][debug][file] [source/common/filesystem/win32/watcher_impl.cc:104] created watch for directory: 'C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2' handle: 0x3a4
[2023-10-06 14:54:14.669][1580][debug][file] [source/common/filesystem/win32/watcher_impl.cc:108] added watch for file 'tmpgiv3amxy-cds.yaml' in directory 'C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2'
[2023-10-06 14:54:14.669][1580][info][config] [source/server/configuration_impl.cc:113] loading 0 listener(s)
[2023-10-06 14:54:14.669][1580][info][config] [source/server/configuration_impl.cc:130] loading stats configuration
[2023-10-06 14:54:14.669][1580][debug][file] [source/common/filesystem/win32/watcher_impl.cc:104] created watch for directory: 'C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2' handle: 0x3c4
[2023-10-06 14:54:14.669][1580][debug][file] [source/common/filesystem/win32/watcher_impl.cc:108] added watch for file 'tmprkxuzs1x-lds.yaml' in directory 'C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2'
[2023-10-06 14:54:14.669][1580][debug][init] [source/common/init/manager_impl.cc:24] added target LDS to init manager Server
[2023-10-06 14:54:14.669][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager RTDS contains no targets
[2023-10-06 14:54:14.669][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager RTDS initialized, notifying RTDS
[2023-10-06 14:54:14.669][1580][info][upstream] [source/common/upstream/cluster_manager_impl.cc:222] cm init: initializing cds
[2023-10-06 14:54:14.669][1580][debug][config] [source/extensions/config_subscription/filesystem/filesystem_subscription_impl.cc:78] Filesystem config refresh for C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2\tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:14.679][1580][info][upstream] [source/common/upstream/cds_api_helper.cc:32] cds: add 1 cluster(s), remove 0 cluster(s)
[2023-10-06 14:54:14.680][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 14:54:14.680][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 14:54:14.680][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 14:54:14.680][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 14:54:14.680][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 14:54:14.680][1580][info][upstream] [source/common/upstream/cds_api_helper.cc:69] cds: added/updated 1 cluster(s), skipped 0 unmodified cluster(s)
[2023-10-06 14:54:14.681][1580][debug][config] [source/extensions/config_subscription/filesystem/filesystem_subscription_impl.cc:88] Filesystem config update accepted for C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2\tmpgiv3amxy-cds.yaml: resources {
[2023-10-06 14:54:14.684][1580][info][upstream] [source/common/upstream/cluster_manager_impl.cc:226] cm init: all clusters initialized
[2023-10-06 14:54:14.684][1580][debug][init] [source/common/init/manager_impl.cc:53] init manager Server initializing
[2023-10-06 14:54:14.684][1580][debug][init] [source/common/init/target_impl.cc:15] init manager Server initializing target LDS
[2023-10-06 14:54:14.684][1580][debug][config] [source/extensions/config_subscription/filesystem/filesystem_subscription_impl.cc:78] Filesystem config refresh for C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2\tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:14.693][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:474] begin add/update listener: name=frontend_listener hash=9854880834967954559
[2023-10-06 14:54:14.693][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:511] use full listener update path for listener name=frontend_listener hash=9854880834967954559
[2023-10-06 14:54:14.693][1580][warning][config] [source/extensions/listener_managers/listener_manager/listener_impl.cc:1099] reuse_port was configured for TCP listener 'frontend_listener' and is being force disabled because Envoy is not running on Linux. See the documentation for more information.
[2023-10-06 14:54:14.693][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:88]   filter #0:
[2023-10-06 14:54:14.693][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:89]     name: envoy.filters.network.http_connection_manager
[2023-10-06 14:54:14.694][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:92]   config: {"@type":"type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager","stat_prefix":"ingress_http","route_config":{"virtual_hosts":[{"name":"adp_fe","domains":["*"],"routes":[{"match":{"prefix":"/"},"route":{"cluster":"service_[...]"}}]}]},"http_filters":[{"name":"envoy.filters.http.grpc_web","typed_config":{"@type":"type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb"}},{"name":"envoy.filters.http.router","typed_config":{"@type":"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router"}}],"server_name":"adp-fe","access_log":[{"name":"envoy.access_loggers.stdout","typed_config":{"@type":"type.googleapis.com/envoy.extensions.access_loggers.stream.v3.StdoutAccessLog"}}],"upgrade_configs":[{"upgrade_type":"websocket"}]}
[2023-10-06 14:54:14.695][1580][debug][config] [C:\botcode\w2\source/common/http/filter_chain_helper.h:89]     http filter #0
[2023-10-06 14:54:14.695][1580][debug][config] [C:\botcode\w2\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.grpc_web
[2023-10-06 14:54:14.695][1580][debug][config] [C:\botcode\w2\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb"}
[2023-10-06 14:54:14.695][1580][debug][config] [C:\botcode\w2\source/common/http/filter_chain_helper.h:89]     http filter #1
[2023-10-06 14:54:14.695][1580][debug][config] [C:\botcode\w2\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.router
[2023-10-06 14:54:14.695][1580][debug][config] [C:\botcode\w2\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router"}
[2023-10-06 14:54:14.696][1580][debug][config] [source/extensions/listener_managers/listener_manager/filter_chain_manager_impl.cc:322] new fc_contexts has 1 filter chains, including 1 newly built
[2023-10-06 14:54:14.696][1580][debug][init] [source/common/init/target_impl.cc:15] init manager Server initializing target Listener-init-target frontend_listener
[2023-10-06 14:54:14.696][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Listener-local-init-manager frontend_listener 9854880834967954559 contains no targets
[2023-10-06 14:54:14.696][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Listener-local-init-manager frontend_listener 9854880834967954559 initialized, notifying Listener-local-init-watcher frontend_listener
[2023-10-06 14:54:14.696][1580][debug][init] [source/common/init/watcher_impl.cc:14] target Listener-init-target frontend_listener initialized, notifying init manager Server
[2023-10-06 14:54:14.696][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_impl.cc:156] Create listen socket for listener frontend_listener on address 127.0.0.1:8888
[2023-10-06 14:54:14.696][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_impl.cc:109] Set listener frontend_listener socket factory local address to 127.0.0.1:8888
[2023-10-06 14:54:14.696][1580][warning][config] [source/extensions/listener_managers/listener_manager/listener_impl.cc:773] ExactBalance was forced enabled for TCP listener 'frontend_listener' because Envoy is running on Windows.ExactBalance is used to load balance connections between workers on Windows.
[2023-10-06 14:54:14.696][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_impl.cc:972] add active listener: name=frontend_listener, hash=9854880834967954559, tag=1, address=127.0.0.1:8888
[2023-10-06 14:54:14.696][1580][info][upstream] [source/extensions/listener_managers/listener_manager/lds_api.cc:86] lds: add/update listener 'frontend_listener'
[2023-10-06 14:54:14.696][1580][debug][init] [source/common/init/watcher_impl.cc:14] target LDS initialized, notifying init manager Server
[2023-10-06 14:54:14.696][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Server initialized, notifying RunHelper
[2023-10-06 14:54:14.696][1580][info][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:858] all dependencies initialized. starting workers
[2023-10-06 14:54:14.696][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 0
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 1
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 2
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 3
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 4
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 5
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 6
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 7
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 8
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 9
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 10
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 11
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 12
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 13
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 14
[2023-10-06 14:54:14.697][1580][debug][config] [source/extensions/listener_managers/listener_manager/listener_manager_impl.cc:895] starting worker 15
[2023-10-06 14:54:14.700][1580][debug][config] [source/extensions/config_subscription/filesystem/filesystem_subscription_impl.cc:88] Filesystem config update accepted for C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2\tmprkxuzs1x-lds.yaml: resources {
[2023-10-06 14:54:15.131][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:15.131][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:15.131][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:15.131][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:15.134][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:15.134][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:15.134][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:15.134][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:20.288][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:20.289][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:20.289][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:20.289][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:20.296][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:20.296][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:20.296][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:20.296][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.080][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.080][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.081][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.081][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.086][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.086][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.086][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.086][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.223][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.223][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.223][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.223][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.243][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.243][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.243][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.243][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.477][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.477][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.477][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.477][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:21.485][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.485][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.485][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:21.485][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.028][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.028][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.028][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.028][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.036][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.036][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.036][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.036][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.262][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.262][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.262][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.262][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:22.273][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.273][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.273][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:22.273][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:23.230][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:23.230][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:23.230][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:23.230][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml
[2023-10-06 14:54:23.238][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:23.238][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:23.239][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 14:54:23.239][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmprkxuzs1x-lds.yaml
[2023-10-06 15:02:59.925][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 1 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:02:59.925][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 1 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:02:59.926][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 3 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:02:59.926][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 3 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:02:59.927][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 3 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:02:59.927][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 3 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:03:36.605][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 15:03:36.606][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 4 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:03:36.606][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3a4 action: 5 file: tmpgiv3amxy-cds.yaml
[2023-10-06 15:03:36.606][5500][debug][file] [source/common/filesystem/win32/watcher_impl.cc:201] matched callback: file: tmpgiv3amxy-cds.yaml
[2023-10-06 15:03:36.605][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 2 file: tmpgiv3amxy-cds.yaml
[2023-10-06 15:03:36.606][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 4 file: tmpgiv3amxy-cds.yaml2
[2023-10-06 15:03:36.606][16672][debug][file] [source/common/filesystem/win32/watcher_impl.cc:188] notification: handle: 0x3c4 action: 5 file: tmpgiv3amxy-cds.yaml
[2023-10-06 15:03:36.606][1580][debug][file] [source/common/filesystem/win32/watcher_impl.cc:130] executing callback
[2023-10-06 15:03:36.606][1580][debug][config] [source/extensions/config_subscription/filesystem/filesystem_subscription_impl.cc:78] Filesystem config refresh for C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2\tmpgiv3amxy-cds.yaml
[2023-10-06 15:03:36.614][1580][info][upstream] [source/common/upstream/cds_api_helper.cc:32] cds: add 11 cluster(s), remove 0 cluster(s)
[2023-10-06 15:03:36.616][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.616][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.616][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.616][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.616][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.618][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.618][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.618][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.618][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.618][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.620][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.620][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.620][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.620][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.620][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.622][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.622][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.622][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.622][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.622][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.623][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.623][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.623][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.624][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.624][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.625][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.625][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.625][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.625][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.625][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.626][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.626][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.626][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.626][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.626][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.627][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.627][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.627][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.627][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.627][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.628][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.628][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.628][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.628][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.628][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.630][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:89]     upstream http filter #0
[2023-10-06 15:03:36.630][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:120]       name: envoy.filters.http.upstream_codec
[2023-10-06 15:03:36.630][1580][debug][config] [C:\botcode\w1\source/common/http/filter_chain_helper.h:123]     config: {"@type":"type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"}
[2023-10-06 15:03:36.630][1580][debug][init] [source/common/init/manager_impl.cc:49] init manager Cluster service_[...] contains no targets
[2023-10-06 15:03:36.630][1580][debug][init] [source/common/init/watcher_impl.cc:14] init manager Cluster service_[...] initialized, notifying ClusterImplBase
[2023-10-06 15:03:36.630][1580][info][upstream] [source/common/upstream/cds_api_helper.cc:69] cds: added/updated 10 cluster(s), skipped 1 unmodified cluster(s)
[2023-10-06 15:03:36.633][1580][debug][config] [source/extensions/config_subscription/filesystem/filesystem_subscription_impl.cc:88] Filesystem config update accepted for C:\Users\adp\AppData\Local\Temp\adp-envoy-config-zfsp3au2\tmpgiv3amxy-cds.yaml: resources {
KBaichoo commented 1 year ago

cc @akshaysngupta

github-actions[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

dimo414 commented 11 months ago

I have yet to see stalebot provide any utility to a single project it is used on. I don't mind that y'all aren't actively acting on this bug but it's a really poor experience to treat such bugs as "stale" and have a bot auto-close them. The message it sends is the project would rather close bugs than act on them.

KBaichoo commented 11 months ago

Hey @dimo414 ,

Sorry for the delay. Windows is mostly supported by folks at microsoft such as @akshaysngupta as most other maintainers, etc. don't have / work on windows.

dimo414 commented 11 months ago

Thanks @KBaichoo, like I said no worries your timing to resolve this specific issue, I've worked around it in the meantime. But stalebot is really bad, would love if y'all could get rid of it.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

dimo414 commented 10 months ago

Go away stalebot.