GeoIP Filter Release Question

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy

https://www.envoyproxy.io

Apache License 2.0

24.78k stars 4.76k forks source link

GeoIP Filter Release Question #30926

Open abebars opened 10 months ago

abebars commented 10 months ago

Title: GeoIP Filter Release Question

Description: Given that MaxMind Geolocation provider was merged https://github.com/envoyproxy/envoy/pull/28490 , I am looking to understand what the process is for getting the GeoIP Extension ready for use

[optional Relevant Links:]

based on @nezdolik comment Tasks to get the filter to Alpha Status:

[x] Handle LDS updates with no crash #30508
[ ] Clean up APIs for GeoIP filter and provider #31001
[ ] Support hot db reload #30250
[x] (optional) support more platforms; currently, the extension is only usable on Linux #30764

htuch commented 10 months ago

@nezdolik

nezdolik commented 10 months ago

@abebars the extension is still in WIP status, major areas of work left to complete:

handle LDS updates with no crash
clean up APIs for geoip filter and provider
support hot db reload
(optional) support more platforms, currently extension is only usable on Linux After this it can be moved to alpha status. Once it gets sufficient production usage time, it will be moved to stable. Practically, one can still use extension as it is now (not recommended for prod), just being aware of limitations mentioned above. E.g. geoip filter end to end flow works with static Envoy config (if no XDS is involved), and "hot db reload" missing feature can be circumvented by restarting Envoy process periodically (Maxmind releases new db versions on weekly or bi-weekly cadence).

abebars commented 10 months ago

Thanks, @nezdolik, for the quick reply. These are good points to start tracking. I would love to contribute to the process and ensure we can get this Filter out in GA status. For now, I can keep this issue open and track the elements you listed above as tasks. I have seen the hot reload task; I would appreciate it if you could provide more guidance on delivering this sooner. Also happy to close this issue if you want track the release somewhere else.

nezdolik commented 10 months ago

@abebars help would be greatly appreciated. If you are interested in helping out, https://github.com/envoyproxy/envoy/issues/31001 needs some attention and old commits in Maxmind PR have examples on how it can be done.