search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.96k stars 4.81k forks source link

envoy_reloadable_features_dfp_mixed_scheme deprecation #31973

Closed alyssawilk closed 1 month ago

alyssawilk commented 9 months ago

Your change #27407 (dns: changing cache keys to include port to avoid issues) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.

alyssawilk commented 9 months ago

@yanavlasov @krajshiva this one is blocked on google yes? AFIK we never closed the loop upstream

krajshiva commented 9 months ago

The problem call site is fixed here https://github.com/envoyproxy/envoy/pull/27641 and is imported so we should be good to use new code. I will verify with the team once more by pinging them.

krajshiva commented 9 months ago

actually there is another team that also has dependency on it. will check with them.

alyssawilk commented 7 months ago

@krajshiva ping on this?

alyssawilk commented 6 months ago

ping :-)

alyssawilk commented 5 months ago

Hey @krajshiva can you circle back on this so we can remove it?