envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.11k stars 4.65k forks source link

Go Network Filter: support enableHalfClose for upstream connection #34196

Closed duxin40 closed 1 week ago

duxin40 commented 2 weeks ago

In summary This PR will add the support to enableHalfClose for upstream connection in go network filter, if user set enableHalfClose to true, reading a remote upstream half-close will not fully close the connection.

Future Plan support for go network filter can be configured together with HCM, so user can specify upstream conn enableHalfClose on L4 and manage traffic on L7.

Let me know if this sounds reasonable, and thank you all for the review!

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

repokitteh-read-only[bot] commented 2 weeks ago

Hi @duxin40, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat: Caused by: https://github.com/envoyproxy/envoy/pull/34196 was opened by duxin40. see: [more](https://github.com/envoyproxy/envoy/pull/34196), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/8c067d20-1358-11ef-9aae-c9ecc1bfa9fb).
doujiang24 commented 2 weeks ago

Thanks @duxin40 , looks good after a quick look, will take a deep look soon.

duxin40 commented 1 week ago

@doujiang24 sorry for clicking on the button (request for review) 😂, could you please help approve again~

doujiang24 commented 1 week ago

Thanks @zuercher , as extension maintainer does not have permission to merge/approve, please help to merge it manually, thanks very much :)

doujiang24 commented 1 week ago

cc @wbpcode @phlax Thanks~