search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.33k stars 4.71k forks source link

Support envoy.service.discovery.v3.ResourceName in response resources. #34285

Open zp9763 opened 2 months ago

zp9763 commented 2 months ago

Title: Support envoy.service.discovery.v3.ResourceName in response resources.

Description: envoy.service.discovery.v3.Resource definition has either name or resource_name field to distinguish it from other resources of the same type. envoy.service.discovery.v3.ResourceName is designed to allow multiple variants of the named resource that are differentiated by dynamic parameter constraints. Currently this is not supported by Envoy - it will reject response resources with ResourceName.

adisuissa commented 2 months ago

Currently this is not supported by Envoy - it will reject response resources with ResourceName.

FWIW, at the moment Envoy will not reject the response but just disregards the field, as it only looks for the name field. It is also worth noting that I'm not aware of any xDS client that supports this field for now (see gRPC support for the name field). That said, eventually this should be supported by Envoy.

cc @krajshiva as this request is from an internal Google team, and we can add it as part of the xDS-TP/Federation work.

RaviTriv commented 1 month ago

Hey, this looks interesting. Is this something I can be assigned?

adisuissa commented 1 month ago

Hey, this looks interesting. Is this something I can be assigned?

@RaviTriv sure, thanks!

RaviTriv commented 1 month ago

Awesome. Getting started on this.

tonya11en commented 5 days ago

Looks like this is the same as https://github.com/envoyproxy/envoy/issues/14428. I'm not actively working on it, but just wanted to link the two issues.

@RaviTriv are you currently working on this issue?

RaviTriv commented 5 days ago

Hey @tonya11en. I haven't made much progress on this issue yet but I would like to continue on this issue if its not something that needs to be done urgently. Thank you!

tonya11en commented 5 days ago

No worries, we don't need this right away. If that changes I'll check back in before we start any work.