Open alyssawilk opened 1 month ago
opentracking is deprecated for a long time, consider remove it?
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.
cc @Shikugawa @basvanbeek thoughts of bumping this to contrib?
makes sense to me
see CI failures on the first push of https://github.com/envoyproxy/envoy/pull/34306
[ RUN ] DynamicOtTracerConfigTest.DynamicOpentracingHttpTracer source/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl.cc:22:40: runtime error: member call on address 0x6020000cb790 which does not point to an object of type 'opentracing::TracerFactory' 0x6020000cb790: note: object is of type 'opentracing::v2::mocktracer::MockTracerFactory' 00 00 00 00 f0 91 cb bf c6 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^
~~~~~~ vptr for 'opentracing::v2::mocktracer::MockTracerFactory'0 0x35511c5 in Envoy::Extensions::Tracers::DynamicOt::DynamicOpenTracingDriver::DynamicOpenTracingDriver(Envoy::Stats::Scope&, std::1::basic_string<char, std::__1::char_traits, std:: 1::allocator > const&, std::1::basic_string<char, std::__1::char_traits, std:: 1::allocator > const&) /proc/self/cwd/source/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl.cc:22:40
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl.cc:22:40 in