search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.29k stars 4.69k forks source link

Debug assertion in Delta XDS (!requested_resource_state_.empty) #34594

Open howardjohn opened 1 month ago

howardjohn commented 1 month ago

Note: this was originally reported privately

Description: Crash logs and another with the same issue Version: Envoy f4930b1ffd7c7bffec32e73f4b7c8482a72dc23a (but Istio build). From yesterday. Core dump

The assertion has been there for a year. We do not always run these tests, so it's likely not a recent regression in Envoy.

Unfortunately, our control plane logs were truncated so we do not have the exact XDS info going on at the time. Probably I can run the test a few more times and get it if it helps. I do know that at the time of the trash, the last XDS push should have been approx 15s prior.

cc @keithmattix

keithmattix commented 1 month ago

I have a sneaking suspicion this is related to #34334; notice my comment. I need to refresh myself on the flow, but that debug assert is probably failing because of a poor assumption

adisuissa commented 1 month ago

Thanks for reporting this. I'll follow up on @keithmattix's comment next week (should have more time to dig into this).

howardjohn commented 1 week ago

Here is another similar one: https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/51437/integ-security-multicluster_istio/1808249482240856064/artifacts/security-c60cc84e078248b3836601/_suite_context/echo1-4-84959-state-4060061412/remote/migration-vistio-df6bc8969-rsrmr_istio-proxy.previous.log

in isInitialRequestForLegacyWildcard this time. There is a core dump.