search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.28k stars 4.69k forks source link

honor connection_pool_per_downstream_connection in tcp conn-pool #34762

Open Pawan-Bishnoi opened 3 weeks ago

Pawan-Bishnoi commented 3 weeks ago

Title: connection_pool_per_downstream_connection is only read in httpConnPoolImpl today. Which means this flag can't be used with filters relying on tcp_pool (eg. thrift_proxy)

Description: the flag is a cluster level flag and should be honored in thrift_proxy etc (which uses tcppool)

Pawan-Bishnoi commented 3 weeks ago

the original PR where this flag was added: https://github.com/envoyproxy/envoy/pull/12812 / https://github.com/envoyproxy/envoy/issues/12370

tyxia commented 2 weeks ago

This PR for this issue has been assigned.

The area should be tcp connection pool and thrift proxy is application