Open wbpcode opened 1 month ago
cc @ohadvano
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.
Title: to deprecate envoy_v3_api_field_config.core.v3.JsonFormatOptions.sort_properties
Description:
This field was introduced in https://github.com/envoyproxy/envoy/pull/29084 and I did the review. But recently, when I delve into the json formatter and related work.
I think maybe I did a wrong decision. The new field basically is meaningless. For users who care the order of json keys, we need to sort the properties. For users who don't care the order, sorting is harmless.
So, the correct decision at that time should be changing the behavior directly to sort the keys. At most we could define a runtime flag for temporary back-forward compatibility.
Recently, I will create a new json formatter for better performance. At there, the sorting will be a default behavior. And after that json formatter instead of the old one, we can also deprecate this field.
[optional Relevant Links:]