envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.99k stars 4.81k forks source link

Upstream health checks threading model #35773

Closed ohadvano closed 2 weeks ago

ohadvano commented 2 months ago

I tried looking it up in docs, but didn't find (please help referring if it exist): Are Envoy upstream health checks performed per-worker, or are they running globally from the main thread, and results are posted to workers? I'd assume the latter, but wanted to make sure

botengyao commented 2 months ago

Yes, health checks are performed on the main thread, and then posted to the thread local configs.

ohadvano commented 2 months ago

Thanks @botengyao, is this documented somewhere? If not, I can add it

botengyao commented 1 month ago

@ohadvano no sure, but feel free to add any docs. Thanks!

github-actions[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 weeks ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.