search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
25.09k stars 4.82k forks source link

Support for future Redis versions Vs. ValKey #36459

Open AnirKulk opened 1 month ago

AnirKulk commented 1 month ago

Title: Is there any discussion around whether the Envoy Redis filter plans to remain (in the future) compatible with Redis or the Open source "equivalent" ValKey project?

Description: Is there any discussion around whether the Envoy Redis filter plans to remain (in the future) compatible with Redis or the Open source "equivalent" ValKey project?

alyssawilk commented 1 month ago

pinging @msukalski @henryyyang @weisisea for commentary

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

AnirKulk commented 2 weeks ago

@msukalski / @HenryYYang / @weisisea can you please comment?

weisisea commented 2 weeks ago

Thanks for the question!

Valkey is currently compatible with existing Redis clients including Envoy Redis filter. As far as I know, in the Valkey open source community, there is no plan to diverge the client interface for the time being. Using CLUSTER SLOTS command to discover cluster topology will continue to be supported by Valkey.

However, it's possible in the future that Redis introduces commands that Valkey doesn't support or vice versa. If that happens, we may need to enhance the Redis filter to be able to detect whether it's talking to Redis or Valkey and then process commands accordingly. If there is a more drastic divergence in the client interface (e.g., using different commands to discover cluster topology and the responses have different formats), we may need to create a new filter for Valkey.