search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
25.07k stars 4.82k forks source link

SAN-matcher: refactoring DNS exact SAN matcher out of regular matchers #37253

Closed adisuissa closed 1 day ago

adisuissa commented 2 days ago

Commit Message: SAN-matcher: refactoring DNS exact SAN matcher out of regular matchers Additional Description: The current SAN-matcher has a specific matching behavior when the matching general-type is DNS and the matcher-type is Exact. This PR refactors that behavior into a different class DnsStringSanMatcher and ensures that when the code creates a SAN-Matcher the correct class is used.

Risk Level: low - internal refactor only Testing: Updated tests. Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A

repokitteh-read-only[bot] commented 2 days ago

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat: Caused by: https://github.com/envoyproxy/envoy/pull/37253 was opened by adisuissa. see: [more](https://github.com/envoyproxy/envoy/pull/37253), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/1eb85a50-a6be-11ef-8dd0-1efe9aa9f3cb).
adisuissa commented 2 days ago

@pradeepcrao can you please take a first pass? /assign @pradeepcrao

soulxu commented 2 days ago

/assign @ggreenway