search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
25.07k stars 4.82k forks source link

json: replacing IS_ENVOY_BUG when a large number value is used with an error #37267

Closed adisuissa closed 19 hours ago

adisuissa commented 1 day ago

Commit Message: json: replacing IS_ENVOY_BUG when a large number value is used with an error Additional Description: Followup to #36919. In #36919, there was a behavior change when the JSON library parsed a large number. Prior to #36919 Envoy would have thrown an exception which ended up rejecting the value or erroring out. After that an ENVOY_BUG was introduced, but probably shouldn't have had, as Envoy may receive a value that is large and should handle it correctly (e.g., when ingesting a config).

This was detected due to fuzz bug 379811166.

Risk Level: low Testing: Added fuzz test case, and updated the unit-tests. Docs Changes: N/A (no docs were updated in the original PR). Release Notes: N/A (no release notes were introduced in the original PR). Platform Specific Features: N/A

repokitteh-read-only[bot] commented 1 day ago

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat: Caused by: https://github.com/envoyproxy/envoy/pull/37267 was opened by adisuissa. see: [more](https://github.com/envoyproxy/envoy/pull/37267), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/8108a2d0-a76f-11ef-8225-86df4ece257b).
adisuissa commented 1 day ago

/assign @alyssawilk