[bp/1.32] opentelemetrytracer: limit calculated sampling exponent in Dynatrace sampler

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy

https://www.envoyproxy.io

Apache License 2.0

25.07k stars 4.82k forks source link

[bp/1.32] opentelemetrytracer: limit calculated sampling exponent in Dynatrace sampler #37281

Closed samohte closed 1 day ago

samohte commented 1 day ago

Commit Message: Backport #37240 Additional Description: Risk Level: Low Testing: Manual Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A [Optional Runtime guard:] N/A [Optional Fixes #37199] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

repokitteh-read-only[bot] commented 1 day ago

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/37281 was opened by samohte. see: [more](https://github.com/envoyproxy/envoy/pull/37281), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/48508a20-a7e2-11ef-8ea3-79d1cce4e2e0).

phlax commented 1 day ago

@samohte @joaopgrassi is this not required for 1.29.x ?

phlax commented 1 day ago

/retest flakey infra

samohte commented 1 day ago

@samohte @joaopgrassi is this not required for 1.29.x ?

@phlax, Thanks for taking care. This code was added in https://github.com/envoyproxy/envoy/commit/97ef386aeb4d12a3fd38f151c38be7decc5c37bf and is not contained in 1.29.