search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
25.07k stars 4.82k forks source link

mobile: allowing for immediate pool drain on network change #37290

Closed alyssawilk closed 14 hours ago

alyssawilk commented 22 hours ago

Risk Level: n/a (mobile only) Testing: new e2e test Docs Changes: n/a Release Notes: n/a

repokitteh-read-only[bot] commented 22 hours ago

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat: Caused by: https://github.com/envoyproxy/envoy/pull/37290 was opened by alyssawilk. see: [more](https://github.com/envoyproxy/envoy/pull/37290), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/e4d46160-a818-11ef-92c3-30d2a358111a).
repokitteh-read-only[bot] commented 22 hours ago

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat: Caused by: https://github.com/envoyproxy/envoy/pull/37290 was opened by alyssawilk. see: [more](https://github.com/envoyproxy/envoy/pull/37290), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/e4d46160-a818-11ef-92c3-30d2a358111a).
alyssawilk commented 15 hours ago

Also as the only !E-M change is a flag addition I'm going to claim it's fine for you to merge with my implicit senior maintainer approval, should you LGTM