envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
25.07k stars 4.82k forks source link

runtime: Deprecate runtime guard `dns_nodata_noname_is_success` #37319

Closed abeyad closed 4 hours ago

abeyad commented 7 hours ago

Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: inline Fixes https://github.com/envoyproxy/envoy-ci-staging/issues/1655

repokitteh-read-only[bot] commented 7 hours ago

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat: Caused by: https://github.com/envoyproxy/envoy/pull/37319 was opened by abeyad. see: [more](https://github.com/envoyproxy/envoy/pull/37319), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/9cb9b100-a8ef-11ef-8032-52299a6f16c3).
abeyad commented 7 hours ago

/assign-from @envoyproxy/senior-maintainers

repokitteh-read-only[bot] commented 7 hours ago

@envoyproxy/senior-maintainers assignee is @ggreenway

:cat: Caused by: a https://github.com/envoyproxy/envoy/pull/37319#issuecomment-2494169047 was created by @abeyad. see: [more](https://github.com/envoyproxy/envoy/pull/37319#issuecomment-2494169047), [trace](https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/aa3c3fa0-a8ef-11ef-9f81-d0f6126cd025).
adisuissa commented 6 hours ago

I think this deprecation should be after the next Envoy version is cut. Otherwise it may be that the flag will be deprecated too early (for those that use Envoy versions). Will leave it to @alyssawilk to determine, as I may be misunderstanding the intention.

phlax commented 6 hours ago

arg - this is probably my fault - it fixes an issue created in our staging repo from my testing the tool - once again, apologies for noise

abeyad commented 4 hours ago

I'm going to close this in favor of doing it for the next release when we get the ping in the main repo