search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.72k stars 4.75k forks source link

Draft PRs: use github's new draft PR feature to reduce CI load #5957

Open junr03 opened 5 years ago

junr03 commented 5 years ago

Draft PRs: use github's new draft PR feature to reduce CI load

Description: Github introduced Draft PRs as a way to create PRs that are a WIP. The maintainers were wondering if this could be used as a heuristic by repo kitteh to reduce the CI load on open PRs. For example, as long as the PR is a draft PR we could run no/or a subset of CI jobs.

itayd commented 5 years ago

There is an SOW item where we always launch a minimal set of CI, and upon requirement (a-la-🔬) , launch the rest.

IIUC, you want to add another layer - running an even more minimal set of tests on drafts?

mattklein123 commented 5 years ago

IIUC, you want to add another layer - running an even more minimal set of tests on drafts?

Yeah exactly, if possible.

itayd commented 5 years ago

I think it is - there is a minimal set of tests that will always run, then if a PR is non-draft more tests are run, and if 🔬 , all tests are run. I consider this part of the SOW.

itayd commented 5 years ago

That said, this only can be done if GitHub has any indication that a PR is draft in the API.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

itayd commented 5 years ago

I'm working on it

On Sat, Mar 16, 2019, 5:08 PM stale[bot] notifications@github.com wrote:

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/envoyproxy/envoy/issues/5957#issuecomment-473603177, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaCa1ZIYTd5CR5TOmTfpvqjb2jqHJ31ks5vXYd-gaJpZM4a8P1m .

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

itayd commented 5 years ago

waiting on circle api