envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.26k stars 4.68k forks source link

redis proxy: add access log #6138

Open incfly opened 5 years ago

incfly commented 5 years ago

Title: Access log not available for redis proxy filter

Description: TCP proxy filter has access log which is useful for debugging. redis proxy however, does not have this field to configure. In a debugging senario, I have to changed to redis proxy to tcp proxy to verify traffic go through envoy.

[optional Relevant Links:]

I'm not so sure the appropriate way to debug the case above and if access log makes sense for networking filter or not. Please feel free to point something that's intended to be used instead.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

tony612 commented 4 years ago

Any progress on this? I thought Redis will have same access logs as TCP proxy.

wbpcode commented 3 years ago

See #13085 May be we need a universal design for all protocols.

dio commented 3 years ago

@cpakulski thoughts?

cpakulski commented 3 years ago

I am targeting this for release 1.18. Not sure about the final form yet. It may be totally flexible or maybe a class would have to derived from a base class. The final goal is to have access log common to various databases understood by Envoy filters: postgres, mysql, redis, mongo, etc.

shanth96 commented 1 year ago

Any update on this?