Open visheyra opened 5 years ago
@alyssawilk Do you know what the correct behavior should be in this case?
The proxy I'm most familiar with intentionally sends 1.0 compatible 1.0 responses to interop with legacy clients. Envoy currently does this as well mainly I wrote our 1.0 compatibility mode for a similar case.
I think it's clear that wanting to send 1.0 responses and wanting to upgrade to 1.1 responses are both totally reasonable. @PiotrSikora might have thoughts on optimal behavior. but per Envoy change guidelines, the easiest change to make would be to add a config option defaulting to current behavior. Folks who are using the 1.0 support will have their existing behavior preserved, and those who want to upgrade the response can turn that up.
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.
not stale
@alyssawilk can you please reopen this? We need this behaviour as well
@alyssawilk I would like to work on this, could you assign this to me if no one else has taken it up already?
Thanks.
Title: HTTP 1.0 / 1.1 : implementation of RFC 2145
Description: According to nginx behaviour and RFC 2145. See this link for a TLDR. One receiving an http1.0 request should reply with either a 1.0 or a 1.1 response but the 1.1 would be prefered.
By creating an HTTP connection manager and allowing the http1.0 and 0.9 protocols as specified in the documentation. If I do a request using http1.0 protocol, a response using the 1.1 protocol should be prefered. Nevertheless I am getting an http1.0 response.
Is this behaviour normal and am i not understanding the RFC correctly or is this a bug ?