search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
24.26k stars 4.68k forks source link

Refactor outlier detection configuration fields #8219

Open csssuf opened 4 years ago

csssuf commented 4 years ago

Title: Refactor outlier detection config message fields

Description: As discussed in https://github.com/envoyproxy/envoy/pull/8130#discussion_r320832679, the outlier detection configuration fields are a bit messy and could use a cleanup. The main work here is to de-dup all of the options into a common message around enabled, local origin split, etc. and then hopefully just have a single field per actual ejection type. This would avoid an explosion of almost identical fields for each different ejection type.

mattklein123 commented 4 years ago

Fixed in https://github.com/envoyproxy/envoy/pull/8221

csssuf commented 4 years ago

Oops, I see now that I used the wrong title in this issue, sorry! My understanding based on the linked PR comment was that there's some refactoring of the OutlierDetection message itself that's desired; #8221 was more of a mechanical fix.

mattklein123 commented 4 years ago

Oh right, sorry, let me reopen and I will add some more detail.

mattklein123 commented 4 years ago

I updated the issue description a bit to hopefully have a bit more info.

htuch commented 4 years ago

I think we should create the new outlier config in v2 and then deprecate the existing one, making the v3 bump a mechanical transition. Marking as help wanted, since this needs implementation work.