Better control on xDS deduplication based on protobuf

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy

https://www.envoyproxy.io

Apache License 2.0

24.86k stars 4.78k forks source link

Better control on xDS deduplication based on protobuf #8301

Open lizan opened 5 years ago

lizan commented 5 years ago

From discussion in https://github.com/envoyproxy/envoy/pull/8231#discussion_r324191998

Key take aways:

Prefer using version_info instead comparing new xDS delivered config with existing one, this also solves https://github.com/envoyproxy/envoy/issues/7676
Add a UUID in ConfigSource for deduplication, instead of hashing ConfigSource proto to automatically dedup. This means RDS/SDS ConfigSource sent from LDS should be deduplicated at control plane.

mattklein123 commented 5 years ago

Add a UUID in ConfigSource for deduplication, instead of hashing ConfigSource proto to automatically dedup. This means RDS/SDS ConfigSource sent from LDS should be deduplicated at control plane.

For discussion, what I said is slightly different, which is to make sure that every resource has a name to use for hashing and lookup, and then use the message differencer Envoy side to look for changes.