search

envoyproxy / envoy

Cloud-native high-performance edge/middle/service proxy
https://www.envoyproxy.io
Apache License 2.0
25.02k stars 4.82k forks source link

Use StringMatcher for route path and header matching #8392

Open htuch opened 5 years ago

htuch commented 5 years ago

As per #next-major-version comments in https://github.com/envoyproxy/envoy/blob/master/api/envoy/api/v2/route/route.proto. We should ideally do this in v2 with new fields and then deprecate the existing matchers, allowing for auto-deletion in v3.

htuch commented 5 years ago

@mattklein123 do you know who might own this work?

mattklein123 commented 5 years ago

I will assign this to myself but leave marked help wanted in case someone else wants to step up.

yittg commented 5 years ago

@htuch @mattklein123 Looks like that we only need to adapt the structured StringMatcher in the configuration parser, maybe I can take it.

yittg commented 5 years ago

One more thing, maybe we can do it along with refactoring the matcher in jwt_authn if needed.

htuch commented 5 years ago

@yittg yes, but there is some subtle issues, e.g. how do you handle the query fragment of the path in a generic way. The ideal is we figure this out and create a parallel match config in v2 (or v3 if this comes after 1.12.0), then deprecate the existing fields.

htuch commented 4 years ago

@mattklein123 are you planning on landing this for 1.13.0 and v3, or do we punt?

mattklein123 commented 4 years ago

No not going to get to this, moving out.