envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.58k stars 344 forks source link

Ensure Envoy recommended edge proxy settings are set by default #1048

Open arkodg opened 1 year ago

arkodg commented 1 year ago

Description: Ensure we are setting Envoy Edge Proxy settings by default to the values specified in https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#configuring-envoy-as-an-edge-proxy

TCP proxies

HTTP proxies:

If Envoy is configured with RBAC filter or makes route selection based on URL path it is recommended to enable the following path normalization options to minimize probability of path confusion vulnerabilities. Path confusion vulnerabilities occur when parties participating in request use different path representations.

Xunzhuo commented 1 year ago

I will work on it.

tanujd11 commented 1 year ago

Hey @Xunzhuo, I would also like to help out with this issue if it's fine with you. I can take up a few of the tasks.

Xunzhuo commented 1 year ago

@tanujd11 can you tell which subtasks you want to assign?

tanujd11 commented 1 year ago

@Xunzhuo I could start from bottom with if it works for you

Xunzhuo commented 1 year ago

Sure @tanujd11

tanujd11 commented 1 year ago

Hey @Xunzhuo , I shall start working on the HTTP proxy tasks. Have you picked any so we don't duplicate the work?

Xunzhuo commented 1 year ago

Feel free please @tanujd11

tanujd11 commented 1 year ago

@arkodg, EG don't support Http3 yet. So I am skipping the h3 connection settings. We can set it once https://github.com/envoyproxy/gateway/issues/422 is done.

arkodg commented 1 year ago

hey @tanujd11 checking in to see if you plan on working on the remaining sub tasks before v0.5.0 releases (end July 2023), else will move this issue into the backlog, thanks in advance !

tanujd11 commented 1 year ago

Hey @arkodg, I will take a look at it on the weekend.

arkodg commented 1 year ago

awesome thanks !

arkodg commented 1 year ago

hey @tanujd11 still planning on working on this in the next few weeks ? if not, will move this into the the next v0.6.0 release milestone, thanks

tanujd11 commented 1 year ago

Hey @arkodg , Ya I was not able to find time. Could you please move it over to next release. Thanks

arkodg commented 1 year ago

thanks for the update @tanujd11 , moving this to v0.6.0-rc1

shahar-h commented 6 months ago

@arkodg overload_manager can be checked as it is completed with #3082.