search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.59k stars 348 forks source link

`TestServeXdsServerListenFailed` panics when `make test` #1204

Closed Xunzhuo closed 1 year ago

Xunzhuo commented 1 year ago

I am using darwin/arm64, running make test will panic like:

image
Xunzhuo commented 1 year ago

cc @muyuan0

muyuan0 commented 1 year ago

Maybe it is relative to https://github.com/agiledragon/gomonkey/issues/10. Would you try the solution at https://github.com/eisenxp/macos-golink-wrapper?

Xunzhuo commented 1 year ago

I think adding this testcase brought less meaning but make it hard for local development, we cannot let every contributor who is using mac to set it up like this way. I always make test before sending a PR.

cc @arkodg @zirain

zirain commented 1 year ago

I will try on darwin/amd64 later.

zirain commented 1 year ago

I will try on darwin/amd64 later.

passed on darwin/amd64

Xunzhuo commented 1 year ago

Looks like only not work in darwin arm64.

arkodg commented 1 year ago

can we skip this test for darwin/arm64, if that is non trivial, we can then consider removing it

muyuan0 commented 1 year ago

Let me find a way to test it without gomonkey this weekend.