search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.64k stars 358 forks source link

egctl x access-logs #1812

Open arkodg opened 1 year ago

arkodg commented 1 year ago

Description:

Add an experimental command similar to https://github.com/envoyproxy/gateway/blob/4285f4e269ff309e81ec24b2f80fa9b5343f6a8f/internal/cmd/egctl/config_cmd.go#L55 to get access-logs from STDOUT if they exist. This is just a helper command which improves productivity in dev environments (eliminates step to read and parse kubectl logs)

shawnh2 commented 1 year ago

interested in working on this one, plz assign

arkodg commented 1 year ago

awesome thanks for picking this one up @shawnh2 , thinking out loud, from an implementation perspective, instead of scraping pod logs to get the access logs, a smarter way could be to temporarily enable the gRPC Access Log server using https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/accesslog/v3/als.proto and any envoy side configurations could be performed using a EnvoyPatchPolicy

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

shawnh2 commented 5 months ago

Do we still need this? I think https://gateway.envoyproxy.io/latest/tasks/observability/proxy-observability/#logs can cover this.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.