envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.64k stars 357 forks source link

egctl x translate should be able to process multiple gatewayclasses #3207

Open shawnh2 opened 7 months ago

shawnh2 commented 7 months ago

Description:

For now, the kubernetesYAMLToResources function in egctl x translate only able to process one GatewayClass, for multiple GC case, the translation will fail.

https://github.com/envoyproxy/gateway/blob/c0068a056f225e136a740823d6d0955cf380374e/internal/cmd/egctl/translate.go#L628

IMO, above function should return something like:

type LoadResources struct {
        Resources

        GatewayClasses  []*gwv1.GatewayClass
        EnvoyProxies    []*egv1a1.EnvoyProxy
}

Any thoughts on this? cc @envoyproxy/gateway-maintainers

[optional Relevant Links:]

Any extra documentation required to understand the issue.

shawnh2 commented 6 months ago

will get to #1295 before resolving this one

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.