search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.51k stars 325 forks source link

Consider moving away from promStatsdExporterContainer #3369

Open arkodg opened 4 months ago

arkodg commented 4 months ago

Description:

Describe the issue.

https://github.com/envoyproxy/gateway/pull/2729 added support for enabling scraping prometheus metrics using a sidecar container based off prom/statsd-exporter:v0.18.0 . Pulling this image is tricky for air gapped clusters and adds another configuration point for syncing an extra image into a private registry

Can this be avoided if ratelimit introduced a prom endpoint natively, tracked with https://github.com/envoyproxy/ratelimit/issues/285

[optional Relevant Links:]

Any extra documentation required to understand the issue.

arkodg commented 3 months ago

hey @shawnh2 interested in investigating the feasibility of this one ? There's a PR linked to the above issue, unsure what's missing to get it through the finish line cc @zirain

zirain commented 3 months ago

I cannot recall all the details last time I tried(it's long ago), most likely because https://github.com/lyft/gostats/pull/119 didn't merge to master.

shawnh2 commented 3 months ago

assign myself now, I will take a deeper look.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

zirain commented 1 month ago

assign this to me

zirain commented 1 month ago

xref: https://github.com/envoyproxy/ratelimit/pull/663