Tweaking overload settings in gateway api?

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway

https://gateway.envoyproxy.io

Apache License 2.0

1.64k stars 357 forks source link

Tweaking overload settings in gateway api? #3604

Open nezdolik opened 5 months ago

nezdolik commented 5 months ago

Description: Since overload manager config is not part of Envoy gateway api and cannot be patched via Envoy patch policy, how could one tweak values for global max downstream connections (except of having to provide custom bootstrap config)?

[optional Relevant Links:]

Any extra documentation required to understand the issue.

arkodg commented 5 months ago

its currently set to 50K https://github.com/envoyproxy/gateway/pull/3082, any alternate values in mind ? hoping we we pick a sane default here, and we can provide an API field in https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#envoyproxy to support modifying it for edge cases

nezdolik commented 5 months ago

@arkodg 50k is good default value, but the actual value very much depends on prod features enabled in the proxy. E.g. at my previous workplace Envoy instance performance was 10x times lower compared to official benchmarks due to custom Java sidecar for ext authz.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

guydc commented 3 months ago

+1 to making overload manager more configurable.

guydc commented 3 months ago

community meeting notes:

bootstrap config can be modified with https://github.com/envoyproxy/gateway/blob/0926b38a5abff4d19546bbe780136db5cba2a80a/api/v1alpha1/envoyproxy_types.go#L361
The current merge capabilities are limited when it comes to lists: https://github.com/envoyproxy/gateway/issues/3691 Since overload manager config is essentially a list of resourceMonitors, the current implementation would not work.
We probably need to support something like jsonpatch here

liorokman commented 2 months ago

@nezdolik Now that #4116 has been merged, is it possible to modify the overload manager configuration as you need it via a JSONPatch?

nezdolik commented 2 months ago

@liorokman thanks for heads up, I will check tomorrow and report back.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.