Better management of application images used by e2e test?

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway

https://gateway.envoyproxy.io

Apache License 2.0

1.59k stars 348 forks source link

Better management of application images used by e2e test? #3866

Closed zirain closed 19 hours ago

zirain commented 3 months ago

right now there're some applications like this in our e2e tests, they're hard to read and mantain. My proposal as following:

Setup up cluster with local registry https://kind.sigs.k8s.io/docs/user/local-registry/
Build images and push them to local registry when setup e2e
Update e2e yaml to use image from local registry.

zirain commented 3 months ago

@envoyproxy/gateway-maintainers PTAL, and share your thought on this.

arkodg commented 3 months ago

hey @zirain your suggestion is the best long term solution, I haven't felt the pain of reading/editing this code so I'd mark this tech debt as lower priority, but maybe others feel differently

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

zirain commented 6 days ago

@arkodg here is my proposal:

move all these apps source code under examples(or tools/src)
add a new make target(make kube-install-examples-image), which build all images and load into kind cluster
change all related yaml files.

arkodg commented 3 days ago

@zirain with this approach, my only concern is resources required for e2e, we are already limited by the GHA runner size, and adding another registry to run will make it harder to run other required things would like to hear what others think @envoyproxy/gateway-maintainers

zirain commented 3 days ago

i didn't add a local registry now, using kind load instead.

arkodg commented 3 days ago

i didn't add a local registry now, using kind load instead.

ah cool, does this work for devs with Mac envs as well ?

zirain commented 3 days ago

yes, worked on my m1.