search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.59k stars 348 forks source link

feat: Better Helm design #4159

Open s0uky opened 1 month ago

s0uky commented 1 month ago

Description: The official Helm chart for the Gateway component should be more robust and comprehensive. Currently, it seems to lack resources for managing deployments of GatewayClass, Gateway, and other child objects associated with CRDs. Values file should be more configurable.

Extract all Kubernetes resource definitions related to the Gateway component from the source code (like this example with statsd: https://github.com/envoyproxy/gateway/blob/301eeddfa4c2f7e4e612874a9c5b13a976156c3e/internal/infrastructure/kubernetes/ratelimit/resource.go#L205 ) and consolidate them into a single location. This improves maintainability over Helm chart.

Ideally, the Helm chart should provide a single point of control to manage the creation and configuration of GatewayClass, Gateway, and other related CRD objects.

zirain commented 1 month ago

prom-statd-exporter issue tracked here.

s0uky commented 1 month ago

Yes, I know about the issue with statsd. My point was it's not good to hardcode any configuration which could be done through Helm.

zirain commented 1 month ago

indeed we should, that's a huge gap between rerfect and real. any controbutions around this is welcome.

github-actions[bot] commented 4 weeks ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days.