search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.55k stars 333 forks source link

feat: support request response sizes stats #4314

Closed luvk1412 closed 1 day ago

luvk1412 commented 5 days ago

Which issue(s) this PR fixes:

Fixes #4234

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.96%. Comparing base (7babca9) to head (bd8fb25). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4314 +/- ## ======================================= Coverage 65.95% 65.96% ======================================= Files 197 197 Lines 23960 23964 +4 ======================================= + Hits 15804 15808 +4 Misses 7028 7028 Partials 1128 1128 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luvk1412 commented 5 days ago

/retest

luvk1412 commented 4 days ago

/retest

luvk1412 commented 4 days ago

--- FAIL: TestGatewayAPIConformance/HTTPRouteSimpleSameNamespace (60.01s) Not sure if this is flaky or not, retest didn't re run conformance test. Any of my change is not related to gw api, so doubt its due to that.

Edit: Passed on next commit, looks flaky.

luvk1412 commented 4 days ago

/retest

zirain commented 2 days ago

can you also add a positive use case?

luvk1412 commented 2 days ago

@zirain just for clarification you want me to add a new file in internal/gatewayapi/testdata right ? I ideally wanted to add a test where generated cluster is validated from input yaml, but i think that's not the case ig for tests in internal/gatewayapi/testdata ? and i can't find in project where such tests exist if they exist.

Edit: added a metric-enabled input file in internal/gatewayapi/testdata for now if that is what is required.

zirain commented 2 days ago

@zirain just for clarification you want me to add a new file in internal/gatewayapi/testdata right ? I ideally wanted to add a test where generated cluster is validated from input yaml, but i think that's not the case ig for tests in internal/gatewayapi/testdata ? and i can't find in project where such tests exist if they exist.

Edit: added a metric-enabled input file in internal/gatewayapi/testdata for now if that is what is required.

can you add xds translator test case

luvk1412 commented 2 days ago

@zirain added xds-translate for xroute and gw testdata as well

luvk1412 commented 2 days ago

/retest

luvk1412 commented 2 days ago

/retest

arkodg commented 2 days ago

would be good to also enhance the grafana dashboard in gateway-addons-helm to make it easier to consume these metrics

luvk1412 commented 2 days ago

would be good to also enhance the grafana dashboard in gateway-addons-helm to make it easier to consume these metrics

you wan it to be done in this pr or i can open a separate issue for that @arkodg ?

arkodg commented 2 days ago

follow up is fine @luvk1412 , thanks

luvk1412 commented 1 day ago

/retest