envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.63k stars 352 forks source link

feat: combine xds-translator and xds-server runners #4326

Closed arkodg closed 3 weeks ago

arkodg commented 1 month ago

Fixes: https://github.com/envoyproxy/gateway/issues/3980

arkodg commented 1 month ago

this is a breaking change

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 65.55%. Comparing base (bd966b8) to head (bb3137a). Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/runner/runner.go 0.00% 52 Missing :warning:
internal/cmd/server.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4326 +/- ## ========================================== - Coverage 65.74% 65.55% -0.19% ========================================== Files 197 196 -1 Lines 23767 23719 -48 ========================================== - Hits 15626 15550 -76 - Misses 7020 7059 +39 + Partials 1121 1110 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkodg commented 1 month ago

looks like the mem usage increased, that looks odd cc @shawnh2